Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disallow registration before epoch #3 #95

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

danielattilasimon
Copy link
Contributor

@danielattilasimon danielattilasimon commented Dec 3, 2024

Timeline:

  • epoch 1: initial initiatives are in warm-up
  • epoch 2: initial initiatives can be voted on
  • epoch 3: registration opens for new initiatives

In practice, we will "skip" epoch 1 by deploying with EPOCH_START backdated by one EPOCH_DURATION, so that initial initiatives can be voted on right from the get-go.

@danielattilasimon danielattilasimon force-pushed the no-immediate-registration branch from 1871291 to 3903836 Compare December 3, 2024 09:32
Timeline:
 - epoch 1: initial initiatives are in warmup
 - epoch 2: initial initiatives can be voted on
 - epoch 3: registration opens for new initiatives

In practice, we will "skip" epoch 1 by deploying with `EPOCH_START`
backdated by one `EPOCH_DURATION`, so that initial initiatives can
be voted on right from the get-go.
@danielattilasimon danielattilasimon force-pushed the no-immediate-registration branch from 3903836 to 531b6fd Compare December 3, 2024 09:32
Copy link
Contributor

@bingen bingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

//
// The reason we want to initially disable registration is that there's not vote snapshot to base the registration
// threshold upon, thus registration would otherwise be possible without having any LQTY staked.
contract DeploymentTest is MockStakingV1Deployer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests here!

@danielattilasimon danielattilasimon merged commit cafde08 into main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants